fix: finished remove child function

1 files changed, 13 insertions, 5 deletions

diff --git a/sys/libbio/phylo.c b/sys/libbio/phylo.c
index d03bc48..316537c 100644
--- a/sys/libbio/phylo.c
+++ b/sys/libbio/phylo.c
@@ -4,6 +4,8 @@
 
 // -----------------------------------------------------------------------
 // subtree manipulation methods
+// NOTE: As of now these don't update nnode & nleaf stats.
+//       It is the caller's responsibility to refresh counts.
 
 error
 phylo·addchild(bio·Node* parent, bio·Node* child)
@@ -26,22 +28,28 @@ SUCCESS:
 }
 
 error
-phylo·rmchild(bio·Node* parent, bio·Node* child)
+phylo·rmchild(bio·Node *parent, bio·Node *child)
 {
     bio·Node *it, *prev;
     enum {
         error·nil,
         error·notfound,
+        error·nochildren,
     };
 
     prev = nil;
-    for (it = parent->child; it != nil && it != child; it = it->sibling) {
+    for (it = parent->child; it != nil; it = it->sibling) {
+        if (it == child) goto FOUND;
         prev = it;
     }
-    if (it == nil) return error·notfound;
-
-
+    return error·notfound;
 
+FOUND:
+    if (prev == nil) {
+        parent->child = child->sibling;
+    } else {
+        prev->sibling = child->sibling;
+    }
     return error·nil;
 }